Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

juliandavidmr
Copy link

Component creation based on basic-virtual-dom

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.4%) to 89.776% when pulling df7ed32 on juliandavidmr:master into a156938 on linuxenko:master.

@juliandavidmr
Copy link
Author

@linuxenko Hi, could you check this PR?

@linuxenko
Copy link
Owner

Hi, @juliandavidmr ! 🎉

I look your component implementation, i have a couple of notes:

  • Wanna say,coveralls isnt happy today and hardcoded parts makes me cry: .
  • The component does not support common component format.
  • The component does not support nesting.
  • The component does not support triggers aka rendering states/events and so on.

But, i didn't said your idea is bad, i really like it, and i could implement/improve component's logic inside of the basic-virtual-dom wrapper named cakejs2, yeah, it still does not support nested Creams. Can you please help me with it ?

@juliandavidmr
Copy link
Author

Hello, @linuxenko
Ok, I'm reviewing cakejs2. I am trying to understand the code to implement more features.
thank you very much for the suggestions and notes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants