Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme and packages #923

Merged
merged 7 commits into from
Jun 30, 2024
Merged

Update theme and packages #923

merged 7 commits into from
Jun 30, 2024

Conversation

thetwopct
Copy link
Collaborator

@thetwopct thetwopct commented Jun 28, 2024

  • Upgraded npm packages and deleted unused ones
  • Update the gulp script and optimised the webpack configuration (more modern packages, less dependencies)
  • Reduced minified CSS size
  • Removed some Foundation CSS
  • Switched out some Foundation bulky CSS files for stripped down custom versions
  • Fixed some CSS maths that the SASS compiler didnt like
  • Preload font on home page
  • Upgrade jQuery to 3.7.1
  • Refactored the src and dist folders and associated build process
  • Removed foundationpress_asset_path() helper
  • Made the Home/About pages use more suitable Heading tags that should be more in order
  • Improved alignment of home page main hero text

PR site: https://pr-923-lfeventsci.pantheonsite.io

Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct thetwopct marked this pull request as ready for review June 28, 2024 15:50
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Copy link
Collaborator Author

thetwopct commented Jun 29, 2024

I've added an npm helper in theme repo - npm run build-plugins this builds all our custom block plugins without needing to go in to each file.

I tried to update any vulnerabilities in the packages in the plugins, but we are restricted by 1) node version of lando/build script (I recommend updating us to 18 or ideally 20) 2) the create-guten-block script which is no longer maintained and 3) @wp-scripts using packages that we cannot use because of node restriction.

Copy link
Collaborator

@cjyabraham cjyabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Is this ready to merge and deploy?

Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Copy link
Collaborator Author

Everything looks good. Is this ready to merge and deploy?

Yes ready to go now

@cjyabraham cjyabraham merged commit 0fb6d6f into main Jun 30, 2024
6 checks passed
@cjyabraham cjyabraham deleted the update-packages-and-theme branch June 30, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants