-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme and packages #923
Conversation
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
I've added an npm helper in theme repo - I tried to update any vulnerabilities in the packages in the plugins, but we are restricted by 1) node version of lando/build script (I recommend updating us to 18 or ideally 20) 2) the create-guten-block script which is no longer maintained and 3) @wp-scripts using packages that we cannot use because of node restriction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Is this ready to merge and deploy?
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Yes ready to go now |
PR site: https://pr-923-lfeventsci.pantheonsite.io