Skip to content

Update Readme for k8s 1.9 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Update Readme for k8s 1.9 #37

merged 1 commit into from
Jan 4, 2018

Conversation

w9n
Copy link
Contributor

@w9n w9n commented Dec 20, 2017

this flag or --discovery-token-ca-cert-hash needs to be set since 1.9
https://github.com/kubernetes/kubeadm/blob/master/docs/design/design_v1.9.md#shared-token-discovery

@GordonTheTurtle
Copy link
Collaborator

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:w9n/kubernetes.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

this flag or `--discovery-token-ca-cert-hash` needs to be set since 1.9
https://github.com/kubernetes/kubeadm/blob/master/docs/design/design_v1.9.md#shared-token-discovery

Signed-off-by: Robin Winkelewski <w9ncontact@gmail.com>
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ijc ijc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suspect the docs should really say "insert whatever join printed out", or perhaps we should fix the issue with the ca being untrusted somehow...

@ijc ijc merged commit a9163c6 into linuxkit:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants