CI updates and tidying #6
Conversation
Left over from development Signed-off-by: Ian Campbell <ijc@docker.com>
.circleci/config.yml
Outdated
| name: Fetch binaries | ||
| command: | | ||
| curl -fsSL -o /workspace/bin/linuxkit https://152-46932243-gh.circle-artifacts.com/0/linuxkit-linux-amd64 | ||
| curl -fsSL -o /workspace/bin/linuxkit https://183-46932243-gh.circle-artifacts.com/0/linuxkit-linux-amd64 |
There was a problem hiding this comment.
since linuxkit/linuxkit#2761 just got merged do you want to roll that in here and ditch moby
There was a problem hiding this comment.
I guess I should, yes. After I figured out where I went wrong with my yaml-fu for the existing stuff ;-)
There was a problem hiding this comment.
Apart from the suggestion of pulling in linuxkit/linuxkit#2761 this def makes things cleaner. Assuming it's green of course...
|
Sadly it seems like my attempt to use I'll take a look through the circle docs to see if there is a higher level feature which allows this, if not then I'll have to drop the most interesting parts of this PR :-( |
Includes linuxkit/linuxkit#2762 which fixes linuxkit#4. Signed-off-by: Ian Campbell <ijc@docker.com>
This will be useful to others I expect. Signed-off-by: Ian Campbell <ijc@docker.com>
Also include all images when listing and use long form of options. Signed-off-by: Ian Campbell <ijc@docker.com>
Signed-off-by: Ian Campbell <ijc@docker.com>
Since linuxkit/linuxkit#2761 (which we have now picked up) we can use `linuxkit build` instead. (NB: we don't currently build images in CI) Signed-off-by: Ian Campbell <ijc@docker.com>
Signed-off-by: Ian Campbell <ijc@docker.com>
|
Yeah, it wasn't possible, force pushed without those nice cleanups. Also updated to an even newer |
|
I made a feature request for being able to refactor like I wanted. |
linuxkitbinary (fixes Cannot boot kube-master using boot.sh when metadata.json is empty #4).circleci/config.ymltoMakefileand refactored.circleci/config.ymlto avoid repetition.linuxkit buildnow.