fix registry auth #4146
Merged
fix registry auth #4146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
fix-buildkit-registry-auth
branch
from
e73f646 to
623bc7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed how linuxkit asks buildkit to do auth, when explicit credentials are provided using CLI. Also, handle the special use case of
docker.io.Does not affect inserting creds from
docker login.- How I did it
With difficulty, until Tonis Tiigi explained the special case.
- How to verify it
CI, plus tests I ran.
- Description for the changelog
Handle docker.io registry-creds correctly.