Removing Window-List applet via Applet Settings GUI also removes all instances of the Grouped-Window-List

[smurphos]

 * Cinnamon version 4.0.9
 * Distribution - Mint 19.1
 * Graphics hardware *and* driver used
Graphics:
  Device-1: Intel 2nd Generation Core Processor Family Integrated Graphics 
  vendor: Hewlett-Packard driver: i915 v: kernel bus ID: 00:02.0 
  chip ID: 8086:0116 
  Display: x11 server: X.Org 1.19.6 driver: modesetting unloaded: fbdev,vesa 
  resolution: 1366x768~60Hz 
  OpenGL: renderer: Mesa DRI Intel Sandybridge Mobile v: 3.3 Mesa 18.0.5 
  compat-v: 3.0 direct render: Yes 
 * 64 bit
 * Attach /home/<username>/.xsession-errors, or /var/log/syslog

Issue
Removing the window-list applet via the Applet's Settings module removes all instances of GWL from all panels. The reverse is not true. Removing the window-list applet via right click on the applet does not have this affect.

Steps to reproduce
Add one or more instances of GWL to any panel and one or more instances of the window-list to a panel.
Remove the window-list via the remove button in the Applet GUI. Observe all instances of GWL also being removed.

No xsession-errors output is noted with this action.

Expected behaviour
Removing with window-list applet should have no impact on any instances of the grouped-window-list

Other information
Behaviour is 100% reproducible - also tried on a fresh user account. Originally reported by another user here https://forums.linuxmint.com/viewtopic.php?p=1578025#p1578025 and subsequently reproduced.

[smurphos]

This is some sort of UUID matching bug in the applet removal functions.

If I create a copy of grouped-window-list@cinnamon.org in ~./local/share/Cinnamon/applets and rename the folder and update the metadata to set the UUID to GWL@cinnamon.org or window-list-grouped@cinnamon.org this avoids the observed behaviour

[Odyseus]

Hello, everybody.

I was able to reproduce this. The problem seems to exist in the disable_extension method of the Spice_Harvester class:

The following condition is problematic:

for enabled_extension in enabled_extensions:
    if uuid not in enabled_extension: # This condition is problematic.
        new_list.append(enabled_extension)

The following condition works:

for enabled_extension in enabled_extensions:
    if uuid != enabled_extension.split(":")[3]: # This condition works.
        new_list.append(enabled_extension)

The following condition might also work (not tested):

for enabled_extension in enabled_extensions:
    if uuid not in enabled_extension.split(":"):
        new_list.append(enabled_extension)

@collinss ?

P.S.: Explanation.

The currently used condition is problematic because it checks the entire string of an enabled xlet for a match. So, if uuid not in enabled_extension: will match the following two enabled xlets strings:

panel1:right:0:window-list@cinnamon.org:40
panel2:right:0:grouped-window-list@cinnamon.org:41

Splitting the string by : character will match the exact UUIDs.

["panel1", "right", "0", "window-list@cinnamon.org", "40"]
["panel2", "right", "0", "grouped-window-list@cinnamon.org", "41"]

[collinss]

Yes, it does look like that is the problem. I suppose we never had an issue with this behavior because we never had 2 uuids with this relationship before. Splitting the strings does seem necessary in this case.