Spices.py: fix a bug causing gwl to be removed when wl is disabled #8309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in which disabling an applet with a uuid that is a sub-string of another uuid will cause both to be disabled. For example, disabling window-list@cinnamon.org will incorrectly cause any instances of grouped-window-list@cinnamon.org to also be removed.
collinss
added a commit
to collinss/cinnamon
that referenced
this pull request
Mar 20, 2019
This was broken by linuxmint#8309 which fixed an issue with applets but the fix didn't consider that desklets and extensions use a slightly different format for the gsettings key. This commit adds handling for all extension types.
clefebvre
pushed a commit
that referenced
this pull request
Mar 20, 2019
This was broken by #8309 which fixed an issue with applets but the fix didn't consider that desklets and extensions use a slightly different format for the gsettings key. This commit adds handling for all extension types.
clefebvre
pushed a commit
that referenced
this pull request
Jun 5, 2019
…8309) This fixes a bug in which disabling an applet with a uuid that is a sub-string of another uuid will cause both to be disabled. For example, disabling window-list@cinnamon.org will incorrectly cause any instances of grouped-window-list@cinnamon.org to also be removed.
clefebvre
pushed a commit
that referenced
this pull request
Jun 5, 2019
This was broken by #8309 which fixed an issue with applets but the fix didn't consider that desklets and extensions use a slightly different format for the gsettings key. This commit adds handling for all extension types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in which disabling an applet with a uuid that is a sub-string of another uuid will cause both to be disabled. For example, disabling window-list@cinnamon.org will incorrectly cause any instances of grouped-window-list@cinnamon.org to also be removed.
Fixes #8282