meta-window-actor.c: Detach after redirecting, not before unredirecting. #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible this was accidentally done due to upstream reversing the logic in this function (set_redirected -> set_unredirected), and the if/else was also reversed. GNOME/mutter@56f8d32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible this was accidentally done due to upstream reversing the
logic in this function (set_redirected -> set_unredirected), and the
if/else was also reversed.
GNOME/mutter@56f8d32
Original mutter patch that added _detach:
GNOME/mutter@2ecc50a
bug report:
https://bugzilla.gnome.org/show_bug.cgi?id=693042
Note: For reference, mutter's current implementation has this reversed once more, though no explanation was given, it occurred during some refactoring. But, our codebase is different enough I'm not going to assume it's correct.
Fixes: linuxmint/cinnamon-screensaver#314