Adding magic/file dep to sync with https://github.com/dgtlmoon/changedetection.io/blob/master/Dockerfile (Required for some favicon handling) #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…detection.io/blob/master/Dockerfile (Required for some favicon handling)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
thespad
approved these changes
Jul 29, 2025
github-project-automation
bot
moved this from PRs
to PRs Approved
in Issue & PR Tracker
|
Appreciate the PR, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to dgtlmoon/changedetection.io#3343 in that the deps for Dockerfile are out of sync, it needs
file(mainly the sub-packagemagic) to handle the favicon typesShould be tested on our end here https://github.com/dgtlmoon/changedetection.io/actions/runs/16590275175/job/46923985976