Skip to content

Add LOG_LEVEL to haproxy config #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Add LOG_LEVEL to haproxy config #29

merged 1 commit into from
Apr 9, 2025

Conversation

aptalca
Copy link
Member

@aptalca aptalca commented Apr 8, 2025

closes #28

@aptalca aptalca requested a review from a team April 8, 2025 16:22
@LinuxServer-CI LinuxServer-CI moved this to PRs Ready For Team Review in Issue & PR Tracker Apr 8, 2025
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/socket-proxy/3.0.9-r0-pkg-3ad5f7cf-dev-52d842ff0e85bf69729de5c6f5c1329a8291ff1f-pr-29/index.html
https://ci-tests.linuxserver.io/lspipepr/socket-proxy/3.0.9-r0-pkg-3ad5f7cf-dev-52d842ff0e85bf69729de5c6f5c1329a8291ff1f-pr-29/shellcheck-result.xml

Tag Passed
amd64-3.0.9-r0-pkg-3ad5f7cf-dev-52d842ff0e85bf69729de5c6f5c1329a8291ff1f-pr-29
arm64v8-3.0.9-r0-pkg-3ad5f7cf-dev-52d842ff0e85bf69729de5c6f5c1329a8291ff1f-pr-29

thespad
thespad previously approved these changes Apr 8, 2025
@github-project-automation github-project-automation bot moved this from PRs Ready For Team Review to PRs Approved in Issue & PR Tracker Apr 8, 2025
@thespad thespad dismissed their stale review April 8, 2025 19:44

Changes

@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to PRs in Issue & PR Tracker Apr 8, 2025
@thespad
Copy link
Member

thespad commented Apr 8, 2025

We should set the LOG_LEVEL in the Dockerfiles so that if the user doesn't pass a value it still works.

@LinuxServer-CI LinuxServer-CI moved this from PRs to PRs Approved in Issue & PR Tracker Apr 9, 2025
@aptalca
Copy link
Member Author

aptalca commented Apr 9, 2025

We should set the LOG_LEVEL in the Dockerfiles so that if the user doesn't pass a value it still works.

Yup, already set: https://github.com/linuxserver/docker-socket-proxy/pull/29/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R44

Copy link
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am blind, apparently

@aptalca aptalca merged commit cf8f9a9 into main Apr 9, 2025
9 checks passed
@aptalca aptalca deleted the loglevel branch April 9, 2025 19:04
@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to Done in Issue & PR Tracker Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Support for LOG_LEVEL was removed
4 participants