Display errors when evaluating or running dweets #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I'd suggest making the error message's font the same as the font used in the rest of the app. |
|
Cool stuff! I just ran into this dweet which has apparently relied on secretly crashing a little, and now it has a big red error! I wonder how many old dweets are affected by this ^^
|
|
Thanks! Addressed this in #159. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you don't have to open dev console to see errors! (Addresses #77.)
The error div is contained inside the dweet iframe, so the iframe now has both a canvas and a div. Dweet code can potentially select and modify the div but this shouldn't be harmful.
Demo:
