This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Add new staticpages backend: external #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the fallback mechanism on backend side
and change the staticpage client-side to skip language choice and fall back to the all_languages function.
This now works with all 3 backends, but is mostly useful for kotti based main navigation.
This adds a permission `static.show_private` which can be requested by static page backends by setting the static page `private` attribute `True`.
Conflicts: src/adhocracy/lib/staticpage.py
This allows to use separate mediacenter and staticpages API endpoints by defining the more special configuration options: * adhocracy_service.mediacenter.rest_api_address * adhocracy_service.mediacenter.rest_api_token * adhocracy_service.staticpages.rest_api_address * adhocracy_service.staticpages.rest_api_token
Additional data fields: : nav, sidebar, description, css_classes (to allow side specific customization).
- use sidebar and full_teaser - wrap everything in a static_wrapper div and apply css_classes there
For some reason the content in the inner blocks isn't shown if these blocks also exist in the inherited template (in this case template.html).
nidico
added a commit
that referenced
this pull request
Mar 31, 2014
Add new staticpages backend: external
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request concludes the Adhocracy side of what has been developed and used in the last year in the long living kotti/staticpages branches.
It can either be used against the
adhocracy.kottipackage which lives in thefeature-kotti-2.2.1branch of liqd/adhocracy or against the plone package in liqd/adhocracy.plone.This also adds a few more features which are only available with the external staticpages backend (automatic navigation creation, permissions) and features which are available with all backends (hierarchical static pages, customizing flags).
Furthermore the database based API is slightly modified in order to work with underscores. I don't quite remember why this happened in this branch, but I'm tired of rebasing this. Also the solution proposed in #676 would be better, but this already improves the status quo.