Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the qbs build #299

Merged
merged 5 commits into from
Oct 11, 2019
Merged

Update to the qbs build #299

merged 5 commits into from
Oct 11, 2019

Conversation

raphaelcotty
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does the code keep building with this change?
  • Do the unit tests pass with this change?
  • Is the commit message formatted according to CONTRIBUTING.MD?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)

Affected core subsystem(s)

Description of change

The changes allow to build and deploy using qbs.
Tested targets are Linux and Android

@raphaelcotty raphaelcotty reopened this Oct 10, 2019
@plfiorini plfiorini self-requested a review October 10, 2019 19:00
Copy link
Member

@plfiorini plfiorini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test now, but lgtm except for missing qbs 1.14 requirement in the main fluid.qbs

Copy link
Member

@plfiorini plfiorini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raise qbs requirement to 1.14

@plfiorini
Copy link
Member

Looks sufficient for Android builds, but Linux builds need more (qtwayland dependency) but it can be done in a separate PR.

@plfiorini plfiorini merged commit a99dc04 into lirios:develop Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants