added ability to collect DOIs of citing papers using OpenCitations #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end I decided to duplicate the collect_citations() infrastructure with collect_citation_dois(). If you don't like that, it could obviously be melded into a single collect_citations() using an argument about which kind of data to collect.
Also I have a question about the code in the original: I can't figure out that stuff about
"# If the return is empty, encode as None instead of zero
This is because we don't want to treat missing data as 0 citations"
I can't see the difference between missing data and 0 citations... what would the json return look like in each case? I just duped that stuff into my code, but I don't understand it TBH