Any problems to concern, if I use S3?

[devhyunjae]

Want to use S3, instead of qiniu

https://github.com/lisong/code-push-server/blob/master/core/utils/common.js#L158

I am planning to replace this part to s3upload.

Seems like there is no problem, but it should be better asking to the owner :)

[lisong]

you can add another option like qiniu，not instead，then ask a pull request for others who need use s3 two. thanks.

[devhyunjae]

OK, I'll try to make an option for storageType: "s3"

[hfyeh]

@devhyunjae @lisong :

I use S3, when I code-push, it shows the error message below. I found I don't know where to put my credential in config.js file for S3, would you help me? Thank you very much!

[lisong]

if you are use npm i code-push-server -g, it suggest download the config file ,then use CONFIG_FILE=/path/to/config.js code-push-server, startup the server. if you use source code then config in config/config.js

[hfyeh]

I use source code and I do edit my config.js, it looks like this

I don't know where could I put my s3 id and key.

[devhyunjae]

@hfyeh
You need to setup AWS credentials. These are not related to code-push-server config.js.
The easiest way is to set these two as env variable.

AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY

http://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/loading-node-credentials-environment.html

[lisong]

@devhyunjae maybe it more better set in config files.

[hfyeh]

Thank you both.

I export it as environment variable and restart server.

When I use pm2, I still get same error message.

But if I use bin/www, it woked. Seems pm2 cannot read my environment variable.

[lisong]

process.json，you can set env in pm2 file，or use the latest commit in master, then config it in config.js