Skip to content

Config variables have to be hidden #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2017
Merged

Config variables have to be hidden #38

merged 1 commit into from
Jan 16, 2017

Conversation

devhyunjae
Copy link
Contributor

fixes #37

  • Use env variables first and then use raw string

@devhyunjae
Hide confs
2a450d6 
* Use env variables first and then use raw string
@coveralls
Copy link

coveralls commented Jan 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 83.824% when pulling 2a450d6 on huiseoul:master into 37cf83c on lisong:master.

@devhyunjae devhyunjae changed the title Config variables has to be hidden Config variables have to be hidden Jan 12, 2017
@devhyunjae
Copy link
Contributor Author

devhyunjae commented Jan 16, 2017 •
edited
Loading

@lisong Can you review this? If you're not interested in using env variables, then I will use my forked repo

@lisong lisong merged commit 0a6d7c2 into lisong:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config variables have to be hidden
3 participants
@devhyunjae @coveralls @lisong