Add aria-label to the version selector component to raise a11y score #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raises score from 92 -> 96 on home page, and 96 -> 100 on /tutorials
|
A live preview of this PR will be available at the URL(s) below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I was running a Chrome lighthouse audit on the new Learn page (#1160) and noted this was bringing down the accessibility score.
How
Add
aria-labelto label the version selector.Impact
Raises Accessibility Lighthouse score from 92 -> 96 on the home page, and 96 -> 100 on /tutorials. Tested by manually running the lighthouse audit.