Skip to content

Conversation

caseywatts
Copy link
Contributor

I read the docs many times before I realized that the nodes I'm querying would not be present until AFTER an update / slotchanged. There is no "initial render" moment for these queries to work on their own.

This PR makes that a bit clearer in the docs ✨

Based on the discussion on Discord: https://discord.com/channels/1012791295170859069/1291879150654849048/1291879150654849048

Thank you @sorvell and Tony 👏

Copy link

google-cla bot commented Oct 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@caseywatts
Copy link
Contributor Author

I signed the CLA and re-ran the scan, but the scan re-run got a 400 error 🤔

@caseywatts
Copy link
Contributor Author

I figured it out!
There's a very slow-loading (10sec+) Captcha that I didn't do the first 3 times

@e111077
Copy link
Collaborator

e111077 commented Feb 26, 2025

/gcbrun

Copy link
Collaborator

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! Made a small edit and put in an info aside. Waiting for site preview to make sure I didn't break anything

@e111077 e111077 merged commit 85391c6 into lit:main Feb 26, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants