Skip to content

Conversation

nkabrown
Copy link
Contributor

Document changes to ContextRequestEvent in @lit/context
lit/lit#4734
Copy link

Important

The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it.

Copy link
Collaborator

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, quick suggestion


- `readonly contextTarget: Element`

The original context target of the requester
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally not a fan of using context target to describe contextTarget. What about something like:

The DOM element that initiated the context request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open a PR on @lit/context to update the param description there so this won't get overwritten when the API docs are automatically generated.

@e111077
Copy link
Collaborator

e111077 commented Feb 26, 2025

Also don't mind the failing CI checks. Pretty sure this happens with forks

EDIT: https://pr1403-e495851---lit-dev-5ftespv5na-uc.a.run.app/docs/data/context/#contextrequestevent

@e111077
Copy link
Collaborator

e111077 commented Feb 26, 2025

/gcbrun

@nkabrown nkabrown requested a review from e111077 February 26, 2025 22:07
@e111077
Copy link
Collaborator

e111077 commented Feb 26, 2025

Thanks for the quick turnaround! 🚀

@e111077 e111077 merged commit 2550526 into lit:main Feb 26, 2025
1 of 2 checks passed
@e111077
Copy link
Collaborator

e111077 commented Feb 26, 2025

deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants