Factor out redirect middleware and run in dev server #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies things like gitignore
Makes it easier to find in vscode etc.
|
A live preview of this PR will be available at the URL(s) below. |
AndrewJakubowicz
approved these changes
Sep 23, 2021
| /** | ||
| * Creates a Koa middleware that performs lit.dev redirection logic. | ||
| */ | ||
| export const redirectMiddleware = (): Koa.Middleware => async (ctx, next) => { |
| @@ -1,13 +1,13 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "incremental": true, | |||
| "tsBuildInfoFile": "./tsconfig.tsbuildinfo", | |||
| "tsBuildInfoFile": "./lib/.tsbuildinfo", | |||
There was a problem hiding this comment.
Tiny nit: Other packages kept this as "./lib/tsconfig.tsbuildinfo".
There was a problem hiding this comment.
Hm interesting. The default is actually <outdir>/.tsbuildinfo which matches this path (https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html). So we could also just omit it.
There was a problem hiding this comment.
I might go through and standardize these in a followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our redirect logic did not work when running in dev mode, since that code was only present in the production server. Now that logic is factored out into a Koa middleware, so that it can run in both places.
I also made a few other changes to make working on the server easier going forward.
In an upcoming PR, I'll be adding a middleware to deal with GitHub auth tokens, so now it will be easier to run that both in production and during local development.