Do not break regex expressions when caching

[binarykitchen]

Hello again,

I notice Lite Speed is modifying code and breaking regex expressions in JavaScript. When the plugin is enabled, I see this error in the browser:

83e922e0dc6b46a25530bfc784899933.js?ver=aa4bc:970 Uncaught SyntaxError: Invalid regular expression: /\bgsa\/([\w\.]+).*safari\],[VERSION,[NAME,'GSA'],[TYPE,INAPP]],[/musical_ly(?:.+app_?version\/|_)([\w\.]+)/i: Unmatched ')

Attached is the corrupt JS file returned by LiteSpeed
83e922e0dc6b46a25530bfc784899933.js

The actual contents are here:
https://github.com/binarykitchen/videomail-for-ninja-forms/blob/develop/target/js/videomail-client/index.min.js#L11192

When I compare both, I can see that you're modifying regexes and hence are breaking other plugins. Can you please investigate? Thanks

[binarykitchen]

FYI, this code comes from this npm package
https://github.com/faisalman/ua-parser-js

From this line:
https://github.com/faisalman/ua-parser-js/blob/master/src/main/ua-parser.js#L456

Make sure your plugin isn't breaking this code.

[timotei-litespeed]

@binarykitchen can you test adding the JS file to setting: https://docs.litespeedtech.com/lscache/lscwp/pageopt/#js-excludes ?

[timotei-litespeed]

@binarykitchen is not the final solution, I want to test if this fixes or not the issue on site

[binarykitchen]

Good idea @timotei-litespeed this helps to narrow down the problem.

Which is your plugin, I am afraid.

I've excluded the JS file and now it's back working. Looks like there is a bug on your side.
You need to review the way how you minify files.

My WordPress plugin is already minified. You don't need to minify all over again:
https://github.com/binarykitchen/videomail-for-ninja-forms

Visual evidence:

[timotei-litespeed]

@binarykitchen
I agree, that is not a a solution
Try adding -min to filename

[timotei-litespeed]

Remember to remove the file from JS Exclude ( https://docs.litespeedtech.com/lscache/lscwp/pageopt/#js-excludes )

[binarykitchen]

No, amending -min doesn't help. I've tested it by renaming, releasing a new version, removing it from the JS excludes and booom, it's broken again :(

You really need to fix this @timotei-litespeed

[timotei-litespeed]

@binarykitchen I tested this scenario
added this script:
wp_enqueue_script( 'custom-script-test', get_template_directory_uri() . '/test-min.js', array( ));
with content:

Tested with diffent settings for JS: minify and combine ON + JS Combine External and Inline
Even with combine and minfy ON the file remains the same, same line breaks and so on.

Between tests make sure you clear all and clear JS/CSS

[binarykitchen]

@timotei-litespeed I don't understand, what are you trying to say, to suggest?

There is a bug in your code, it seems. Are you working on it?

(I do not see any buttons with clear all and clear JS/CSS)

[timotei-litespeed]

@binarykitchen
I am trying to suggest to rename minified file to end with -min.js
This way LSC will leave it: will NOT minify it further, It will just combine it

[binarykitchen]

I already did that yesterday, released a new version of my plugin and it's still broken.

Try to install my plugin and test it for yourself.

[timotei-litespeed]

@binarykitchen I have added a request to whitelist my domain. Please accept it

[binarykitchen]

Great @timotei-litespeed I've just whitelisted your test domain. Please change the site name ID to litespeedTestPage then it should show up.

[timotei-litespeed]

Ok, you can see the test link(please do not share it)
I added it to homepage, you can test it there.

No special settings, I just enabled these:

From what I see it works, camera starts, it records.