(fix)resource-chaoslib: run command with a shell instance #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ksatchit <karthik.s@mayadata.io>
ispeakc0de
approved these changes
Aug 14, 2020
|
cc: @andreas131989 ! |
ksatchit
pushed a commit
to ksatchit/litmus-go
that referenced
this pull request
Aug 15, 2020
…s#81) Signed-off-by: ksatchit <karthik.s@mayadata.io>
ksatchit
pushed a commit
that referenced
this pull request
Aug 15, 2020
* chore(probe): Adding probes in all go experiments (#80) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io> * (fix)resource-chaoslib: run command with a shell instance (#81) Signed-off-by: ksatchit <karthik.s@mayadata.io> * refactor(go-experiments): Refactor all the go experiments (#82) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io> * chore(exp): Add pod autoscaler experiment used to check the scalability of the application pod (#65) * chore(exp): Add pod autoscaler experiment used to check the salability of the application pod Signed-off-by: Udit Gaurav <uditgaurav@gmail.com> * Adding abort in the experiment Signed-off-by: Udit Gaurav <udit.gaurav@mayadata.io> * update(chaosresult): updating the chaosresult for probe score (#85) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io> * refactor(pod-autoscaler): refactor the pod-scaler experiment (#86) Signed-off-by: shubhamchaudhary <shubham.chaudhary@mayadata.io> Co-authored-by: Shubham Chaudhary <shubham.chaudhary@mayadata.io> Co-authored-by: UDIT GAURAV <35391335+uditgaurav@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the resource (cpu, memory) chaoslib to read commands from the command_string operand instead of from the standard input while performing the exec operation.
This should help make the command execution more predictable as we force execution with /bin/sh regardless of entrypoint.
Towards fix: CPU hog experiment fails to inject chaos litmus#1861
Again, these still apply only to target containers that offer a shell.
Signed-off-by: ksatchit karthik.s@mayadata.io