Skip to content

Conversation

FelixJacobi
Copy link
Member

@FelixJacobi FelixJacobi commented Mar 20, 2022

fix #121.

The main BigBlueButton class is also marked as @final. I decided against to also make it final as this is breaking DX too much in my opinion. We would need an Interface to allow that, or you are not able to mock the class anymore. This should be postponed to version 5.1+. For now, it is a reminder, that you should not extend the class in your code.

  • This PR points to 5.0 branch. 5.0 will be developed with 4.3 in parallel, like explained in Policy for BC breaks and feature changes #122.
  • 5.0 will have the same features as 4.3 minus Deprecations and plus BC Breaks.
  • When 4.3 was branched and released, 5.0 branch will be merged back to master. Until this is done, every merge to master requires an "upmerge" to the 5.0 branch.

@FelixJacobi FelixJacobi added this to the 5.0 milestone Mar 20, 2022
@FelixJacobi FelixJacobi requested review from SamuelWei and sualko March 20, 2022 01:51
@FelixJacobi
Copy link
Member Author

Merged as it got the required peer approvals already.

@FelixJacobi FelixJacobi merged commit cedd8ee into 5.0 Jun 10, 2022
@FelixJacobi FelixJacobi deleted the mark-classes-final branch July 29, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants