Skip to content

Do not downgrade layers too early #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2021
Merged

Do not downgrade layers too early #61

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
854e1a7
v0.13.4
davidzhao Oct 23, 2021
961ff94
Merge branch 'raja_delay_downgrade' of github.com:livekit/client-sdk-…
boks1971 Oct 25, 2021
d2be069
Revert accidental delete
boks1971 Oct 25, 2021
4a14999
proper revert
boks1971 Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/room/track/LocalVideoTrack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,12 @@ export default class LocalVideoTrack extends LocalTrack {
return;
}

// if best layer has not sent anything, do not downgrade till the
// best layer starts sending something. It is possible that the
// browser has not started some layer(s) due to cpu/bandwidth
// constraints
if (sendStats.framesSent === 0) return;

// if we've upgraded or downgraded recently, give it a bit of time before
// downgrading again
if (this.lastExplicitQualityChange
Expand Down