Skip to content

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Oct 26, 2021

but only if it was caused by mediatrack ended event.

Reasoning:
When screensharing is stopped via browser UI, it comes in handy to subscribe to TrackUnpublished

this.currentRoom.localParticipant.on(ParticipantEvent.TrackUnpublished, async (track) => {
			log.debug('local track unpublished (most likely by browser), stop screen share');

the naming and default behaviour is mirrored from RemoteParticipant.ts

@davidzhao
Copy link
Member

This is a good call @lukasIO. We've been talking about how to handle this across all of our SDKs in a consistent manner. The challenge with using TrackUnpublished is that it's supposed to only reflect a remote track (as defined by the docs today).

We'll discuss and update this PR with feedback.

@lukasIO
Copy link
Contributor Author

lukasIO commented Oct 31, 2021

closing in favor of #72

@lukasIO lukasIO closed this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants