Skip to content

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Oct 29, 2021

Right now setting the name property in the track publish option like

	await this.currentRoom.localParticipant.publishTrack(audioTrack, {
					name: `my-microphone`
				});

doesn't have any effect if the track is not an instance of MediaStreamTrack.
This PR overrides the track name if it is set explicitly via options also for a LocalTrack type.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@davidzhao davidzhao merged commit 95db324 into livekit:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants