Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call out flags with abnormal behavior #101

Merged
merged 4 commits into from
Jan 24, 2022
Merged

Call out flags with abnormal behavior #101

merged 4 commits into from
Jan 24, 2022

Conversation

hthillman
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jan 19, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/livepeer/docs/6MhHFyfFAkd1rTueAPBqSB2MYEao
✅ Preview: https://docs-git-hh-configuration-livepeer.vercel.app

@hthillman hthillman mentioned this pull request Jan 20, 2022
Closed
@jvventura
Copy link
Contributor

jvventura commented Jan 20, 2022 •
edited
Loading

@hthillman I recommend that the wording says "any onchain process with ethUrl flag" for the reward section, because I figured out that my reward call was in fact not coming from my -orchestrator, but a separate -transcoder process that had ethUrl and shared the same wallet as my Orchestrator. So it seems the reward service is by default true for Transcoders as well under some circumstances.

@vercel vercel bot temporarily deployed to Preview January 20, 2022 19:39 Inactive
@hthillman
Copy link
Contributor Author

hthillman commented Jan 20, 2022 •
edited
Loading

updated per your comment 👍

lmk if this gets the point across

@vercel vercel bot temporarily deployed to Preview January 20, 2022 21:46 Inactive
@vercel vercel bot temporarily deployed to Preview January 20, 2022 22:51 Inactive
yondonfu
yondonfu approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hthillman hthillman merged commit 732fe9a into main Jan 24, 2022
@0xcadams 0xcadams deleted the hh-configuration branch February 15, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hthillman @jvventura @yondonfu