Add ctx to logging for selection algorithm #1826
leszkotest.yaml
on: pull_request
Run tests defined for the project
6m 40s
Perform CodeQL analysis
3m 47s
Run editorconfig checker
7s
Annotations
6 errors and 11 warnings
|
Run tests defined for the project:
server/selection_algorithm_test.go#L211
not enough arguments in call to sa.filter
|
|
Run tests defined for the project:
server/selection_test.go#L163
cannot use stubSelectionAlgorithm{} (value of type stubSelectionAlgorithm) as "github.com/livepeer/go-livepeer/common".SelectionAlgorithm value in argument to NewMinLSSelector: stubSelectionAlgorithm does not implement "github.com/livepeer/go-livepeer/common".SelectionAlgorithm (wrong type for method Select)
|
|
Run tests defined for the project:
server/selection_test.go#L239
cannot use stubSelectionAlgorithm{} (value of type stubSelectionAlgorithm) as "github.com/livepeer/go-livepeer/common".SelectionAlgorithm value in argument to NewMinLSSelector: stubSelectionAlgorithm does not implement "github.com/livepeer/go-livepeer/common".SelectionAlgorithm (wrong type for method Select)
|
|
Run tests defined for the project:
server/selection_test.go#L340
cannot use selAlg (variable of type stubSelectionAlgorithm) as "github.com/livepeer/go-livepeer/common".SelectionAlgorithm value in argument to NewMinLSSelector: stubSelectionAlgorithm does not implement "github.com/livepeer/go-livepeer/common".SelectionAlgorithm (wrong type for method Select)
|
|
Run tests defined for the project:
server/selection_test.go#L371
cannot use stubSelectionAlgorithm{} (value of type stubSelectionAlgorithm) as "github.com/livepeer/go-livepeer/common".SelectionAlgorithm value in argument to NewMinLSSelector: stubSelectionAlgorithm does not implement "github.com/livepeer/go-livepeer/common".SelectionAlgorithm (wrong type for method Select)
|
|
Run tests defined for the project
Process completed with exit code 1.
|
|
Run tests defined for the project
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run tests defined for the project:
cmd/livepeer_bench/livepeer_bench.go#L189
should replace realTimeSegCount += 1 with realTimeSegCount++
|
|
Run tests defined for the project:
cmd/simple_auth_server/simple_auth_server.go#L17
struct field Url should be URL
|
|
Run tests defined for the project:
eth/types/contracts.go#L49
struct field NextUnbondingLockId should be NextUnbondingLockID
|
|
Run tests defined for the project:
test/e2e/e2e.go#L35
context.Context should be the first parameter of a function
|
|
Run tests defined for the project:
verification/epic_test.go#L173
parameter 'r' seems to be unused, consider removing or renaming it as _
|
|
Run tests defined for the project:
discovery/discovery.go#L64
should omit 2nd value from range; this loop is equivalent to `for i := range ...`
|
|
Run tests defined for the project:
test/e2e/configure_orchestrator_test.go#L40
context.Context should be the first parameter of a function
|
|
Run tests defined for the project:
cmd/livepeer/starter/starter.go#L911
error strings should not be capitalized or end with punctuation or a newline
|
|
Run tests defined for the project:
verification/verify_test.go#L59
parameter 'params' seems to be unused, consider removing or renaming it as _
|
|
Run tests defined for the project:
discovery/wh_discovery.go#L32
exported func NewWebhookPool returns unexported type *discovery.webhookPool, which can be annoying to use
|