Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include original source in the annotation #1191

Conversation

NduatiK
Copy link
Contributor

@NduatiK NduatiK commented Dec 13, 2023

@NduatiK NduatiK force-pushed the include-original-source-in-the-annotation branch from 25e11fd to 6f732f5 Compare December 13, 2023 17:10
Copy link
Contributor

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we hold off on merging until the client-side parsing is updated? I'll open a PR against this branch.

@carson-katri
Copy link
Contributor

Will source always be a single line?

@carson-katri
Copy link
Contributor

@bcardarella @NduatiK Do you have a preferred way for this to be displayed on the client? Here are a few options, but with the metadata it can be formatted in any way:

Stylesheet parsing failed for modifier `bold` in class `font-bold`:

/Users/carson.katri/Documents/LiveViewNative/ElixirConf23Apps/elixirconf_chess/lib/elixirconf_chess_web/styles/app_styles.ex:66
   | defmodule ElixirconfChessWeb.Styles.AppStyles do
   | ...
66 | bold()
   | ^ No matching clause found for modifier 'bold'. Expected `bold(_:)`
Stylesheet parsing failed for modifier `bold` in class `font-bold`:

ElixirconfChessWeb.Styles.AppStyles (/Users/carson.katri/Documents/LiveViewNative/ElixirConf23Apps/elixirconf_chess/lib/elixirconf_chess_web/styles/app_styles.ex:66)
   |
66 | bold()
   | ^ No matching clause found for modifier 'bold'. Expected `bold(_:)`
Stylesheet parsing failed for modifier `bold` in class `font-bold`:

   |
66 | bold()
   | ^ No matching clause found for modifier 'bold'. Expected `bold(_:)`

in ElixirconfChessWeb.Styles.AppStyles (/Users/carson.katri/Documents/LiveViewNative/ElixirConf23Apps/elixirconf_chess/lib/elixirconf_chess_web/styles/app_styles.ex:66)

@bcardarella
Copy link
Collaborator

@carson-katri #3 looks good to me

@carson-katri
Copy link
Contributor

PR open here: NduatiK#1

@NduatiK
Copy link
Contributor Author

NduatiK commented Dec 14, 2023

Will source always be a single line?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include original source in the annotation
3 participants