Skip to content

update node sdk with streaming/non-streaming return type fix #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

update node sdk with streaming/non-streaming return type fix #5

merged 2 commits into from
Jan 31, 2025

Conversation

yanxi0830
Copy link
Contributor

@yanxi0830 yanxi0830 commented Jan 31, 2025 •
edited
Loading

What

Test

npm test examples/
./examples/inference.ts
./examples/agents.ts
image

@yanxi0830 yanxi0830 changed the title Sync updates from stainless branch: yanxi0830/dev update node sdk with streaming/non-streaming return type fix Jan 31, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 31, 2025
@yanxi0830 yanxi0830 marked this pull request as ready for review January 31, 2025 20:33
ashwinb
ashwinb approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!!

@yanxi0830 yanxi0830 merged commit c0b94e3 into main Jan 31, 2025
1 check passed
@yanxi0830 yanxi0830 deleted the stream-non-stream-2 branch January 31, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb ashwinb approved these changes

@hardikjshah hardikjshah Awaiting requested review from hardikjshah

@dltn dltn Awaiting requested review from dltn

@raghotham raghotham Awaiting requested review from raghotham

+1 more reviewer

@vladimirivic vladimirivic vladimirivic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanxi0830 @ashwinb @vladimirivic @facebook-github-bot