Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precommit enhancement #400

Closed
wants to merge 1 commit into from

Conversation

parteekcoder
Copy link

issue #399

Adding a precommit will ensure some basic checks like eslint before pushing code , which ease the contributor to correct it before pushing and waiting for the workflow to check

@NikhilM98 @llaske I will appreciate your suggestions and work upon them

@parteekcoder parteekcoder changed the base branch from master to dev March 18, 2023 16:01
@parteekcoder
Copy link
Author

When contributor commits it automatically runs

image

@NikhilM98
Copy link
Collaborator

This feature was removed in 77d47ac5d.

@llaske is it still needed?

@llaske
Copy link
Owner

llaske commented Mar 18, 2023

No I don't think we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants