Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display language settings in 2 languages #292

Closed
YJDave opened this issue Mar 12, 2019 · 6 comments
Closed

Display language settings in 2 languages #292

YJDave opened this issue Mar 12, 2019 · 6 comments
Labels
enhancement to be release Fixed, to be release
Milestone
v1.2

Comments

@YJDave
Copy link
Contributor

YJDave commented Mar 12, 2019

Languages in Language setting should not be translated according to local/browser language. So "English" should be "English" even if my local language of browser is "French" or something else.

image

Why?
Suppose I change my local language to "French", languages list in setting also changed, and I am no longer be able to change language back to "English" as I couldn't understand which one of the option was "English" as all options were translated to "French".
@YJDave YJDave mentioned this issue Mar 12, 2019
Merged
@llaske
Copy link
Owner

llaske commented Mar 12, 2019

I don't think it's a problem. English is at first and name of languages are understandable in most languages.
I never seen this sort of double translation elsewhere. Did you?

@YJDave
Copy link
Contributor Author

YJDave commented Mar 13, 2019

I was not sure whether double translation is the most suitable solution. But I do think that there should be some way that allows user to see languages names without translated to local language.
I have seen this double-translated language list setting on Twitter, not checked other applications.
image

What could be the appropriate solution to this problem, according to you?

llaske added a commit that referenced this issue Mar 17, 2019
@llaske
Display language settings in 2 languages
0cd4903 
#292: Languages in "Language settings" should be non-translated.
@llaske llaske changed the title user settings: Languages list in "Language setting" should be non-translated. Display language settings in 2 languages Mar 17, 2019
@llaske llaske added enhancement to be release Fixed, to be release labels Mar 17, 2019
@llaske
Copy link
Owner

llaske commented Mar 17, 2019

Fixed in 0cd4903

@YJDave
Copy link
Contributor Author

YJDave commented Mar 25, 2019

Closing the issue as it is fixed!

@YJDave YJDave closed this as completed Mar 25, 2019
@llaske llaske reopened this Mar 26, 2019
@llaske
Copy link
Owner

llaske commented Mar 26, 2019

I don't close issue before release of a new version.

@llaske llaske added this to the v1.2 milestone Apr 10, 2019
@llaske
Copy link
Owner

llaske commented Sep 26, 2019

Closed in dd3c58d

@llaske llaske closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
2 participants
@llaske @YJDave