JS solution and tests for Issue #18 - Find missing number in array of… #54
Conversation
…ray of consecutively increasing numbers
test/18.js
Outdated
| expect(result).to.equal(7); | ||
| }); | ||
|
|
||
| it('should return 94 for [89,90,91,92,93]', () => { |
There was a problem hiding this comment.
description incomplete. [...91, 92, 93, 95]
solutions/18.js
Outdated
| let missingNum = null, | ||
| i = 0; | ||
|
|
||
| while (!missingNum && i < arr.length - 1) { |
There was a problem hiding this comment.
food for thought. Since there is only 1 missing number, and your goal is to return that number, you might not even need the missingNum variable. start i = 1.
while (i < arr.length -1 && arr[i-1] +1 === arr[i] )....
You don't have to make this change, just food for thought. Good job!
test/18.js
Outdated
| const result = solution([1,2,3,4,5]); | ||
| expect(result).to.equal(null); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
could you add a test case for negative numbers please? thx.
…iption for test case two
|
@songz Thanks for the feedback! I liked your approach to the solution, so I just added it as an alternative one in the bottom of the file. Had to make one change to the while condition so that I could also return null if no missing number is found. |
solutions/18.js
Outdated
| * @param {Number[]} arr - An array of consecutively increasing numbers | ||
| * @returns {Number|null} missingNum - the number missing from the input array or null if none is found | ||
| */ | ||
| // const solution = arr => { |
There was a problem hiding this comment.
instead of commenting out previous solution, could you rename them? solution, solution1, and export all the solutions.
|
CONGRATS! This is a great solution to issue #18 |
… consecutively increasing numbers