Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles Grouping/Sorting #1770 #1883

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Styles Grouping/Sorting #1770 #1883

merged 5 commits into from
Mar 11, 2024

Conversation

hswlab
Copy link
Contributor

@hswlab hswlab commented Jan 11, 2024

As described in #1770 (comment)

mashb1t
mashb1t requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@mashb1t mashb1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small code style changes

css/style.css Outdated Show resolved Hide resolved
javascript/script.js Outdated Show resolved Hide resolved
@mashb1t mashb1t linked an issue Jan 12, 2024 that may be closed by this pull request
Styles Grouping/Sorting #1770
Closed
hswlab and others added 2 commits January 13, 2024 10:35
@hswlab @mashb1t
Update css/style.css
375c264 
Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>
@hswlab @mashb1t
Update javascript/script.js
3a45c30 
Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>
@hswlab
Copy link
Contributor Author

hswlab commented Jan 13, 2024

It's my first PR with review at github, I hope I didn't miss to click something ^^'.

@xhoxye xhoxye mentioned this pull request Feb 3, 2024
Merged
@mashb1t mashb1t added the Size M medium change, isolated, testing with care label Feb 9, 2024
@mashb1t mashb1t added this to the 2.3.0 (draft) milestone Mar 11, 2024
@mashb1t mashb1t changed the base branch from main to develop March 11, 2024 15:32
@mashb1t mashb1t merged commit 2831dc7 into lllyasviel:develop Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashb1t mashb1t mashb1t approved these changes

@lllyasviel lllyasviel Awaiting requested review from lllyasviel lllyasviel is a code owner

Assignees
No one assigned
Labels
Size M medium change, isolated, testing with care
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Styles Grouping/Sorting
2 participants
@hswlab @mashb1t