Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing dependencies on pypi install #23

Closed
lucpeterson opened this issue Dec 4, 2019 · 4 comments
Closed

[BUG] Missing dependencies on pypi install #23

lucpeterson opened this issue Dec 4, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@lucpeterson
Copy link
Member

Describe the bug
pip install from pypi doesn't grab all the necessary dependencies

To reproduce

  1. python3 -m virtualenv "testy"
  2. source testy/bin/activate
  3. pip install merlinwf
  4. merlin
    -> breaks
    "ModuleNotFoundError: No module named 'tabulate'"
  5. pip install tabulate
  6. merlin
    -> breaks
    ModuleNotFoundError: No module named 'maestrowf'
  7. pip install -e git+https://github.com/LLNL/maestrowf.git#egg=maestrowf
  8. merlin
    -> success

Expected behavior
pip install merlinwf should grab all dependencies

@lucpeterson lucpeterson added the bug Something isn't working label Dec 4, 2019
@lucpeterson
Copy link
Member Author

#31

@ben-bay
Copy link
Contributor

ben-bay commented Dec 4, 2019

tabulate has been added to release.txt on develop, and will be fixed in the next upload to PyPI. maestrowf, however, remains a problem.

@koning
Copy link
Member

koning commented Dec 5, 2019

maestrowf fixed with #42

@ben-bay
Copy link
Contributor

ben-bay commented Dec 5, 2019

maestrowf fixed with #42

...or so we thought. PyPI isn't allowing URL installs, so for now we wait until Maestro on PyPI gets load_specification_from_stream in v1.1.5, which Frank says whould come later today.

@ben-bay ben-bay closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants