Fix pkgconfig file install location & include directory #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apps are doing #include <yajl/yajl_parse.h> to get yajl headers,
but the pkgconfig file sets includedir={prefix}/include/yajl.
This means the compiler will look for
/usr/include/yajl/yajl/yajl_parse.h
This isn't a problem when prefix is /usr since /usr/include is
in the default search path, so the compiler will still find
/usr/include/yajl/yajl_parse.h. If you install yajl to somewhere
else like $HOME/usr, then the broken pkgconfig file includedir
setting will prevent the compiler finding the header files
at all
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
The pkgconfig tool has two directories for installing .pc files to /usr/share/pkgconfig /usr/lib/pkgconfig The /usr/share/pkgconfig directory must only be used if the .pc file refers to resources which are architecture independant. Since yajl is a native C library, it is very much architecture dependant and so must use /usr/lib/pkgconfig Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
|
this is a dup of #119 |
|
The patch against #119 is wrong because it doesn't honour LIB_SUFFIX, which this patch of mine does do. Also the second patch here fixes the pkgconfig file contents which the other patch doesn't. |
|
👍 |
This was referenced Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.