Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

globalStringPtr now returns returns a constant (changed to use a cons… #258

Merged
merged 1 commit into from
May 15, 2019
Merged

globalStringPtr now returns returns a constant (changed to use a cons… #258

merged 1 commit into from
May 15, 2019

Conversation

jfaure
Copy link
Contributor

@jfaure jfaure commented Apr 21, 2019

…tant Gep instruction)

cocreature
cocreature approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Sorry for not responding earlier, I somehow managed to completely miss that. Feel free to ping me if I don’t respond within a week or so next time.

@cocreature cocreature merged commit 07e9b53 into llvm-hs:llvm-8 May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfaure @cocreature