Refactoring of Dockerfile #41
Conversation
…the individual source languages.
…r C but in the sense of continuity it is to have 'its own' Dockerfile env.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -0,0 +1 @@ | |||
| Dockerfile.cpp_env No newline at end of file | |||
There was a problem hiding this comment.
I don't think C and C++ need a separate container. It's not even possible to build clang with support for only one or the other and system packages between them will probably have a large amount of overlap.
There was a problem hiding this comment.
C is only a symbolic link to the C++ container, but just having it in there for continuity's sake s.t. every language has its own container..
There was a problem hiding this comment.
Why though? We collect C and C++ from the same builders (spack and Gentoo, although Gentoo needs its own container).
Have you validated that packages still build? The list of dependencies was long in the first place because it increased the percentage of packages that would build. I don't think I ever kept exact notes of what needed what though. |
Refactor the existing Dockerfile into language-specific Dockerfiles, laying the groundwork for adding the other builders. Namely:
Dockerfile.cpp_envDockerfile.julia_envDockerfile.rust_envDockerfile.swift_envDockerfile.c_envpoints at the C++ Dockerfile, but yet exists for continuity's sake.The list of system-dependencies was pruned in the process.
cc @lwshanbd @jdoerfert