Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HWLegalizeModules] Legalize array concat op #5355

Closed
uenoku opened this issue Jun 10, 2023 · 0 comments · Fixed by #6402
Closed

[HWLegalizeModules] Legalize array concat op #5355

uenoku opened this issue Jun 10, 2023 · 0 comments · Fixed by #6402
Labels
bug Something isn't working HW Involving the `hw` dialect

Comments

@uenoku
Copy link
Member

uenoku commented Jun 10, 2023

Support hw.array_concat in HWLegalizeModules

$ ./build/bin/firtool perf/regress/chipyard.TestHarness.RocketSmall1Medium1Big1_BoomMedium1Large1Mega1.top.v.hi.fir -o foo.sv --lowering-options=disallowLocalVariables,disallowPackedArrays
Arbiters.scala:42:16: error: unsupported packed array expression
Arbiters.scala:42:16: note: see current operation: %57 = "hw.array_concat"(%3, %56) : (!hw.array<3xi1>, !hw.array<5xi1>) -> !hw.array<8xi1>
@uenoku uenoku added the HW Involving the `hw` dialect label Jun 10, 2023
@uenoku uenoku mentioned this issue Jun 21, 2023
Closed
@seldridge seldridge added the bug Something isn't working label Jul 25, 2023
@uenoku uenoku mentioned this issue Oct 20, 2023
Closed
yupferris added a commit to yupferris/circt that referenced this issue Nov 9, 2023
@yupferris
[HWLegalizeModules] Lower types-like packed array handling (llvm#5355)
47b2d2e 
This PR refactors HWLegalizeModules to something more like existing lower types passes in order to support more complex patterns such as array concatenations. Several new tests are also added.

Fix llvm#5355.
@yupferris yupferris mentioned this issue Nov 9, 2023
Merged
@oharboe oharboe mentioned this issue Nov 9, 2023
Open
2 tasks
yupferris added a commit to yupferris/circt that referenced this issue Nov 10, 2023
@yupferris
[HWLegalizeModules] Lower types-like packed array handling (llvm#5355)
751393c 
This PR refactors HWLegalizeModules to something more like existing lower types passes in order to support more complex patterns such as array concatenations. Several new tests are also added.

Fix llvm#5355.
yupferris added a commit to yupferris/circt that referenced this issue Nov 10, 2023
@yupferris
[HWLegalizeModules] Lower types-like packed array handling (llvm#5355)
29cf79d 
This PR refactors HWLegalizeModules to something more like existing lower types passes in order to support more complex patterns such as array concatenations. Several new tests are also added.

Fix llvm#5355.
yupferris added a commit to yupferris/circt that referenced this issue Nov 10, 2023
@yupferris
[HWLegalizeModules] Lower types-like packed array handling (llvm#5355)
bf712b0 
This PR refactors HWLegalizeModules to something more like existing lower types passes in order to support more complex patterns such as array concatenations. Several new tests are also added.

Fix llvm#5355.
uenoku pushed a commit that referenced this issue Nov 10, 2023
@yupferris
[HWLegalizeModules] Lower types-like packed array handling (#5355) (#…
97c770c 
…6402)

This PR refactors HWLegalizeModules to something more like existing lower types passes in order to support more complex patterns such as array concatenations. Several new tests are also added.

Fix #5355.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working HW Involving the `hw` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HWLegalizeModules] Lower types-like packed array handling (#5355) yupferris/circt
2 participants
@seldridge @uenoku