Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HW] Remove getGroundFields from FieldIDTypeInterface #5126

Merged
merged 1 commit into from
May 3, 2023
Merged

[HW] Remove getGroundFields from FieldIDTypeInterface #5126

merged 1 commit into from
May 3, 2023

Conversation

youngar
Copy link
Member

@youngar youngar commented May 3, 2023

This function does not appear to be used anywhere. I am motivated to remove it as I don't know what value to return for union-like types.

@youngar
[HW] Remove getGroundFields from FieldIDTypeInterface
d7d6aed 
This function does not appear to be used anywhere. I am motivated to
remove it as I don't know what value to return for union-like types.
@youngar youngar requested a review from seldridge May 3, 2023 17:10
dtzSiFive
dtzSiFive approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh joy, I ran into similar re:refs/aggs-with-refs, as yes appears unused. LGTM, thanks!

@youngar youngar merged commit 9568bef into llvm:main May 3, 2023
@youngar youngar deleted the firrtl-getgroundtypes branch May 3, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngar @dtzSiFive