Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIREmitter] Support Open aggregates, RefSubOp #5179

Merged
merged 3 commits into from
May 17, 2023
Merged

[FIREmitter] Support Open aggregates, RefSubOp #5179

merged 3 commits into from
May 17, 2023

Conversation

dtzSiFive
Copy link
Contributor

@dtzSiFive dtzSiFive commented May 11, 2023 •
edited
Loading

Support exporting these types + ops, especially ref.sub. Allows exporting refs-in-aggs.mlir file.

Added basic test.

@dtzSiFive dtzSiFive force-pushed the feature/emitter-refsub-openaggs branch from a9e8819 to a2df0ef Compare May 16, 2023 15:55
@dtzSiFive dtzSiFive requested a review from seldridge May 16, 2023 15:55
@dtzSiFive dtzSiFive added the FIRRTL Involving the `firrtl` dialect label May 16, 2023
@dtzSiFive dtzSiFive mentioned this pull request May 16, 2023
Closed
@dtzSiFive dtzSiFive merged commit 00ddb34 into llvm:main May 17, 2023
@dtzSiFive dtzSiFive deleted the feature/emitter-refsub-openaggs branch May 17, 2023 01:06
@seldridge
Copy link
Member

Awesome. Thanks for adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @seldridge