Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRParser] Add support for parsing String types #5362

Merged
merged 1 commit into from
Jun 12, 2023
Merged

[FIRParser] Add support for parsing String types #5362

merged 1 commit into from
Jun 12, 2023

Conversation

youngar
Copy link
Member

@youngar youngar commented Jun 12, 2023

No description provided.

@youngar youngar added the FIRRTL Involving the `firrtl` dialect label Jun 12, 2023
@youngar youngar requested review from mikeurbach and rwy7 June 12, 2023 18:43
mikeurbach
mikeurbach approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm less familiar with the FIRRTL parser, but makes sense to me.

@youngar youngar merged commit f720426 into llvm:main Jun 12, 2023
@youngar youngar deleted the firrtl-parse-string branch June 12, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwy7 rwy7 rwy7 approved these changes

@mikeurbach mikeurbach mikeurbach approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youngar @mikeurbach @rwy7