[FIRRTL][InferResets] Fix reset inference through const cast. #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update these as operations that cannot have types inferred from inputs, drop (incomplete) code handling while propagating through SSA use/def graph. In order to support updating in this way, we'd need to walk the source/dest type and update modulo the const structure present on each. Luckily don't need to, this portion is for flowing through operations not explicitly handled as part of the traced network. ConstCast is handled this way, and so its destination type can be fixed up using `updateReset()` earlier in the function. Fix reset inference of const-cast involving aggregates, add test. Fixes llvm#5333.
dtzSiFive
force-pushed
the
fix/issue-5333
branch
from
61c8bee
to
d7cd793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update these as operations that cannot have types inferred from inputs, drop (incomplete) code handling while propagating through SSA use/def graph. In order to support updating in this way, we'd need to walk the source/dest type and update modulo the const structure present on each.
Luckily don't need to, this portion is for flowing through operations not explicitly handled as part of the traced network. ConstCast is handled this way, and so its destination type can be fixed up using
updateReset()earlier in the function.Fix reset inference of const-cast involving aggregates, add test.
Fixes #5333.