[FIRRTL][ExpandWhens] Support properties #5373
Merged
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds initialization checking of Property typed ports to the ExpandWhens pass. This ensures that output properties of modules and input properties of instances are driven by a PropAssignOp.
mikeurbach
approved these changes
Jun 12, 2023
dtzSiFive
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
LGTM! Glad this was as easy as this, woohoo!
In the future may be useful to teach Visitor about FConnectLike to facilitate handling of all connect-like operations in one go, then this would be even easier.
Anyway, looks good, thanks for splitting these apart!
rwy7
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds initialization checking of Property typed ports to the ExpandWhens pass. This ensures that output properties of modules and input properties of instances are driven by a PropAssignOp.