[FIRRTL][LowerTypes] Support RefCast. #5377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
commented
Jun 13, 2023
| auto clone = [&](const FlatBundleFieldEntry &field, | ||
| ArrayAttr attrs) -> Value { | ||
| auto input = getSubWhatever(op.getInput(), field.index); | ||
| return builder->create<RefCastOp>(RefType::get(field.type), input); |
There was a problem hiding this comment.
ref.sub demotes rwprobe to probe, but since we don't break up rwprobe's that's not a concern here 👍 .
dtzSiFive
force-pushed
the
feature/refcast-lowertypes
branch
from
12251c6
to
30f617a
Compare
|
Great, thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.