[FIRRTL] Support const "source" in forces, insert refcast as needed. #5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In addition to supporting const-related situations, this makes examples such as this work: https://github.com/dtzSiFive/reftype-inputs/blob/main/force_infer.fir (well, once #5378 lands). |
youngar
approved these changes
Jun 13, 2023
Instead of being non-ref, require they're base.
|
Thanks! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better support literal and literal/const-derived sources to "force", and use ref.cast to accommodate supported differences.
This is not required by the current FIRRTL spec, but makes using it a bit easier.
Also this handles various const scenarios re:aggregates, current code seems primarily to get ground types/literals accepted.