[FIRRTL][InferWidths] Handle foreign and prop types uniformly #5392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes InferWidths to use a common pattern to filter out foreign and property types. The
getBaseType(FIRRTLType)
function now takes aType
and returns null if it is not aFIRRTLType
.declVars
and all three constrain functions now usegetBaseType
and a null-check to skip over foreign and property types. This changes the behavior ofmaximumOfTypes
andunifyTypes
, but this is not a testable code path.