[FIRRTL][InferWidths] Handle foreign and prop types uniformly #5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes InferWidths to use a common pattern to filter out foreign and property types. The `getBaseType(FIRRTLType)` function now takes a `Type` and returns null if it is not a `FIRRTLType`. `declVars` and all three constrain functions now use `getBaseType` to skip over foreign and property types. This changes the behaviour of `maximumOfTypes` and `unifyTypes`, but this is not a testable code path.
dtzSiFive
approved these changes
Jun 13, 2023
| inline FIRRTLBaseType getBaseType(FIRRTLType type) { | ||
| return TypeSwitch<FIRRTLType, FIRRTLBaseType>(type) | ||
| inline FIRRTLBaseType getBaseType(Type type) { | ||
| return TypeSwitch<Type, FIRRTLBaseType>(type) |
There was a problem hiding this comment.
Should this support a null type? Nice to be able to assume input is not null, but just curious re:how these might chain/be used.
There was a problem hiding this comment.
I think traditionally the dyn_cast_or_null function can handle a null argument, and we have getBaseTypeOrNull which I guess should be updated to null-check and then forward to this function. Also to make the name clearer we should rename this to follow the new upstream name for this dyn_cast_if_present, i.e. getBaseTypeIfPresent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes InferWidths to use a common pattern to filter out foreign and property types. The
getBaseType(FIRRTLType)function now takes aTypeand returns null if it is not aFIRRTLType.declVarsand all three constrain functions now usegetBaseTypeand a null-check to skip over foreign and property types. This changes the behavior ofmaximumOfTypesandunifyTypes, but this is not a testable code path.