[FIRRTL] Clean up instances in ExtractClasses. #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
|
This is currently based on #5394. |
uenoku
reviewed
Jun 13, 2023
uenoku
reviewed
Jun 14, 2023
After classes are extracted from FIRRTL modules, the property ports of the module are removed. This patch extends the pass to also update instances of mutated modules, so their instantiations remain correct. It also removes modules that only existed for properties.
mikeurbach
force-pushed
the
mikeurbach/firrtl-extract-classes-cleanup
branch
from
5549542
to
b6d6a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After classes are extracted from FIRRTL modules, the property ports of the module are removed. This patch extends the pass to also update instances of mutated modules, so their instantiations remain correct. It also removes modules that only existed for properties.