Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Add BigIntConstantOp #5397

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[FIRRTL] Add BigIntConstantOp #5397

merged 1 commit into from
Jun 13, 2023

Conversation

youngar
Copy link
Member

@youngar youngar commented Jun 13, 2023

No description provided.

@youngar youngar added the FIRRTL Involving the `firrtl` dialect label Jun 13, 2023
@youngar youngar requested review from mikeurbach and rwy7 June 13, 2023 23:16
mikeurbach
mikeurbach approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems in line with what we discussed briefly, looks good to me.

@youngar youngar merged commit 87897b7 into llvm:main Jun 13, 2023
@youngar youngar deleted the firrtl-constbigint branch June 13, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeurbach mikeurbach mikeurbach approved these changes

@rwy7 rwy7 Awaiting requested review from rwy7

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngar @mikeurbach