Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Add mux cell intrinsics #5428

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Jun 20, 2023

This commit adds intrinsics (int.muxcell4, muxcell2) for directely representing 4-wide and 2-wide MUX cells in the backend. With these operations, we can construct N-to-1 mux at the Chisel level.

This commit includes ODS definition, LowerIntrinsic, LowerTypes, InferWith, and folder change (only for mux2).

LowerToHW change will be done after #5427 which would require more iterations.

@uenoku uenoku force-pushed the dev/uenoku/firrtl-mux-intriics branch 3 times, most recently from 15dadab to d222857 Compare June 20, 2023 14:20
This commit adds intrinscis (int.synopsys.mux4, mux2) for directely
representing 4-to-1 and 2-to1 MUX cells in the synopys backend.
With these operations, we can construct N-to-1 mux opitmized for
synopsys target at the Chisel level

This commit includes ODS definition, LowerTypes, InferWith, and folder
change (only for mux2).
@uenoku uenoku force-pushed the dev/uenoku/firrtl-mux-intriics branch from d222857 to 7dde93e Compare June 20, 2023 14:41
Copy link
Contributor

@darthscsi darthscsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want synopsys specific and replicate for cadence, or is there a comonality?

@uenoku uenoku force-pushed the dev/uenoku/firrtl-mux-intriics branch from 1c06cde to eabc6eb Compare June 21, 2023 08:13
@uenoku uenoku changed the title [FIRRTL] Add synopsys mux intrinsics [FIRRTL] Add mux cell intrinsics Jun 21, 2023
@uenoku uenoku force-pushed the dev/uenoku/firrtl-mux-intriics branch from eabc6eb to 8e1c00b Compare June 21, 2023 08:18
@uenoku
Copy link
Member Author

uenoku commented Jun 21, 2023

Changed to common operations based on the offline discussion

Copy link
Contributor

@darthscsi darthscsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uenoku uenoku merged commit 5e96218 into main Jun 21, 2023
@uenoku uenoku deleted the dev/uenoku/firrtl-mux-intriics branch June 21, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants